Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Fix for keyboard navigationwhen search-enabled is false #1543

Closed
wants to merge 25 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ac0c72f
fix(search-enabled) keyboard navigation does not work when search-ena…
fcaballero Mar 30, 2016
5f04993
fix(indentation) use 2 spaces, no tabs
fcaballero Mar 31, 2016
0babb6a
fix(indentation) use 2 spaces, add white-space
fcaballero Apr 17, 2016
9ee18ec
fix(build): fix sourcemap logic
wesleycho Mar 30, 2016
a221994
chore(bower): update version
wesleycho Mar 30, 2016
e740649
chore: normalize line endings
wesleycho Mar 31, 2016
46b719c
feat(perf): optimize width resizing
wesleycho Mar 29, 2016
2785b43
build(css) fix missing dist/select.css
user378230 Apr 4, 2016
db205cb
docs(*) update examples and automate build
user378230 Mar 31, 2016
b5f09cb
fix(tagging): do not remove selected items when invalid
meyerds Dec 15, 2015
6f47a3d
fix: ensure highlighted before selecting on tab
jintoppy Jun 19, 2015
158ffa9
fix(a11y): prevent list from being focusable
Apr 29, 2015
df68b98
revert: ensure highlighted before selecting on tab
wesleycho Apr 6, 2016
bf834b2
refactor(uiSelectChoices) only compile template once
user378230 Apr 6, 2016
ab5ad17
fix: show select element when search is disabled
dometec Apr 16, 2015
56a7de2
fix(sortable): remove classes properly
homerjam Mar 28, 2016
c990206
fix(autocomplete): change to type="search"
ruipenso Jun 3, 2015
dff74e3
docs(examples) fix double header/footer wrapping
user378230 Apr 6, 2016
aa3b1ff
fix(bootstrap) do not overflow matched item text
just-boris Apr 7, 2016
a2c1e56
revert: fix(bootstrap) do not overflow matched item text
user378230 Apr 7, 2016
6d15343
fix(bootstrap): hide clear button if disabled
Raytray Apr 7, 2016
ba37f13
fix(uiSelectSingleDirective): strictly compare matching value
fiznool Apr 16, 2016
c9fb884
perf: change test in ctrl.isActive
Teegrounet Apr 17, 2016
0d63e5d
fix (tagging): try all taggingTokens for splitting on paste
torstenrudolf Apr 24, 2016
ff4818b
fix(search-enabled) keyboard navigation does not work when search-ena…
fcaballero Mar 30, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# This file is for unifying the coding style for different editors and IDEs
# editorconfig.org

root = true

[*]
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

# Tabs in JS unless otherwise specified
[**.js]
indent_style = space
indent_size = 2

[*.md]
trim_trailing_whitespace = false
6 changes: 6 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
*.html eol=lf
*.css eol=lf
*.js eol=lf
*.md eol=lf
*.json eol=lf
*.yml eol=lf
20 changes: 19 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ language: node_js
node_js:
- "5.9"
env:
- CXX=g++-4.8
global:
- CXX=g++-4.8
- GH_REF: github.com/angular-ui/ui-select.git
- GH_PAGES_BRANCH: gh-pages
- secure: "PkIhXXwrR5fHh7fH+2WizaY0MmK1l1Dr7PCqs112PkEimVPcntRJeA5pjTwGRwHm+RSkFVtfo38EY/GUwzhLSRTO7WZ+id+vIMGQLgiofqrOwi0nq93esG6qI8Jg5K0GUt8mzg5m9B2tgm2I91RAojEhIukKcbsDsq3hNAUy71Y="

addons:
apt:
sources:
Expand All @@ -16,6 +21,19 @@ before_script:
- npm install --quiet -g gulp

script: "gulp test"

after_success:
- "gulp docs"

deploy:
skip_cleanup: true
provider: "script"
script: "bash ./deploy-docs.sh"
on:
all_branches: true
# on:
# tags: true

sudo: false

git:
Expand Down
47 changes: 19 additions & 28 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,53 +1,43 @@
# AngularJS ui-select [![Build Status](https://travis-ci.org/angular-ui/ui-select.svg?branch=master)](https://travis-ci.org/angular-ui/ui-select)
# AngularJS ui-select [![Build Status](https://travis-ci.org/angular-ui/ui-select.svg?branch=master)](https://travis-ci.org/angular-ui/ui-select) [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/angular-ui/ui-select?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)

[![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/angular-ui/ui-select?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
AngularJS-native version of [Select2](http://ivaynberg.github.io/select2/) and [Selectize](http://brianreavis.github.io/selectize.js/). [http://angular-ui.github.io/ui-select/](http://angular-ui.github.io/ui-select/)

AngularJS-native version of [Select2](http://ivaynberg.github.io/select2/) and [Selectize](http://brianreavis.github.io/selectize.js/).
[Getting Started](https://github.com/angular-ui/ui-select/wiki/Getting-Started)

[Getting Started](https://github.com/angular-ui/ui-select/wiki/Getting-Started) `bower install angular-ui-select`

- [Demo](http://plnkr.co/edit/a3KlK8dKH3wwiiksDSn2?p=preview)
- [Demo Multiselect](http://plnkr.co/edit/juqoNOt1z1Gb349XabQ2?p=preview)
- [Examples](https://github.com/angular-ui/ui-select/blob/master/examples)
- [Examples](http://angular-ui.github.io/ui-select/#examples)
- [Examples Source](./docs/examples)
- [Documentation](https://github.com/angular-ui/ui-select/wiki)

## Last Changes
## Latest Changes

- Check [CHANGELOG.md](/CHANGELOG.md)

## Features

- Search, Select, and Multi-select
- Themes: Bootstrap, Select2 and Selectize
- Search, Select, Multi-select and Tagging
- Multiple Themes: Bootstrap, Select2 and Selectize
- Keyboard support
- jQuery not required (except for old browsers)
- No jQuery required (except for old browsers)
- Small code base: 4.57KB min/gzipped vs 20KB for select2

For the roadmap, check [issue #3](https://github.com/angular-ui/ui-select/issues/3) and the [Wiki page](https://github.com/angular-ui/ui-select/wiki/Roadmap).

## Installation using [Composer](http://getcomposer.org/)

Make sure composer is install globally before we proceed. After that we need to add below piece of code in `composer.json` file located inside your project root folder.
## Installation Methods

### npm
```
{
"require": {
"components/ui-select": "dev-master"
}
}
$ npm install angular-ui-select
```
### bower
```
$ bower install angular-ui-select
```

- Run `composer update` and composer will install the component.
- Inside your HTML add below script and link tags.
- select.js: `<script src="components/ui-select/dist/select.min.js"></script>`
- select.css: `<link rel="stylesheet" href="components/ui-select/dist/select.min.css">`


## Development

### Prepare your environment
* Install [Node.js](http://nodejs.org/) and NPM (should come with)
* Install global dev dependencies: `npm install -g bower gulp`
* Install global dev dependencies: `npm install -g gulp`
* Install local dev dependencies: `npm install` in repository directory

### Development Commands
Expand All @@ -56,11 +46,12 @@ Make sure composer is install globally before we proceed. After that we need to
* `gulp build` to jshint and build
* `gulp test` for one-time test with karma (also build and jshint)
* `gulp watch` to watch src files to jshint, build and test when changed
* `gulp docs` build docs and examples

## Contributing

- Check [CONTRIBUTING.md](/CONTRIBUTING.md)
- Run the tests
- Try the [examples](https://github.com/angular-ui/ui-select/blob/master/examples)
- Try the [examples](./docs/examples)

When issuing a pull request, please exclude changes from the "dist" folder to avoid merge conflicts.
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-ui-select",
"version": "0.14.1",
"version": "0.16.1",
"homepage": "https://github.com/angular-ui/ui-select",
"authors": [
"AngularUI"
Expand Down
31 changes: 31 additions & 0 deletions deploy-docs.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#!/bin/bash
set -e

[[ $TRAVIS_SECURE_ENV_VARS == "true" ]] || { echo "No github key avaliable, aborting publishing"; exit 0; }

ID_REF="$(git rev-parse --short HEAD)"

git clone "https://${GH_KEY}@${GH_REF}" ./docs-out -b ${GH_PAGES_BRANCH} --single-branch --depth=1

cd docs-out

# clear out everything
git rm -rf .
git clean -fxd

# get new content
cp ../docs-built/* . -R

git add .

# inside this git repo we'll pretend to be a new user
git config user.name "Travis CI"
git config user.email "[email protected]"

# The first and only commit to this new Git repo contains all the
# files present with the commit message "Deploy to GitHub Pages".
git commit -m "docs(*): new deploy (angular-ui/ui-select@${ID_REF})"


git push origin --quiet
#> /dev/null 2>&1
18 changes: 9 additions & 9 deletions dist/select.js
Original file line number Diff line number Diff line change
Expand Up @@ -2038,15 +2038,15 @@ uis.service('uisRepeatParser', ['uiSelectMinErr','$parse', function(uiSelectMinE
// When using (key,value) ui-select requires filters to be extracted, since the object
// is converted to an array for $select.items
// (in which case the filters need to be reapplied)
if (match[3]) {
// Remove any enclosing parenthesis
source = match[5].replace(/(^\()|(\)$)/g, '');
// match all after | but not after ||
var filterMatch = match[5].match(/^\s*(?:[\s\S]+?)(?:[^\|]|\|\|)+([\s\S]*)\s*$/);
if(filterMatch && filterMatch[1].trim()) {
filters = filterMatch[1];
source = source.replace(filters, '');
}
if (match[3]) {
// Remove any enclosing parenthesis
source = match[5].replace(/(^\()|(\)$)/g, '');
// match all after | but not after ||
var filterMatch = match[5].match(/^\s*(?:[\s\S]+?)(?:[^\|]|\|\|)+([\s\S]*)\s*$/);
if(filterMatch && filterMatch[1].trim()) {
filters = filterMatch[1];
source = source.replace(filters, '');
}
}

return {
Expand Down
1 change: 1 addition & 0 deletions docs/assets/app.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
var module = angular.module('ui.select.pages', ['plunkr']);
Loading