fix(uiSelectChoices) broken id interpolation #1533
Conversation
| openDropdown(el); | ||
|
|
||
| var generatedId = el.scope().$select.generatedId; | ||
| expect($(el).find('[id$="row-' + generatedId + '-0"]').length).toEqual(1); |
There was a problem hiding this comment.
You can change this to $(el).find('#row-' + generatedId + '-0')
There was a problem hiding this comment.
Would this capture all elements if they shared that id? (In case a bug was introduced)
I haven't jQuery'd in years, according to http://stackoverflow.com/a/6744674 it wouldn't? I'll have to check later.
There was a problem hiding this comment.
Ah, I see what you're doing here - I think it would be better to just use the whole id, for simplicity.
$(el).find('#ui-select-choices-row-' + generatedId + '-0')
|
Other than the minor adjustment, LGTM. |
|
Hi guys, sorry for the noise, I should not create pull request this early in the morning… The full id selector should be ☕ |
|
Dumb convention question: Should’nt the build files be included in the PR ? |
The id attribute on ui-select-choices-row is no longer interpolated correctly when using ui select with angular v1.5+. This change switches to using ng-attr-id to ensure the id value is correctly interpolated before being assigned to the element. Fixes angular-ui#1522
The id attribute on ui-select-choices-row is no longer interpolated correctly when using ui select with angular v1.5+.
This change switches to using ng-attr-id to ensure the id value is correctly interpolated before being assigned to the element.
Fixes #1522