Fix tolerance for null or undefined values

[homerjam]

Re-pull of #1035

[user378230]

Was this causing an actual issue? (Thinking in terms of if we can add a test for this somehow..)

[homerjam]

I did this a while ago but yes I believe it was causing the directive to break. I think a test would just need to give a null/undefined value for the model.

[user378230]

@homerjam can you add one and then I can merge in? It's best for them to be part of the same commit, ideally.

[homerjam]

Sure. I'll definitely give it a go

[user378230]

@homerjam just to confirm, these test fail without your change right?

[wesleycho]

Those tests currently pass without the changeset from the PR.

[homerjam]

Ah yes I meant to to say. I think this fix may have been to make sure the
placeholder text appeared on a null/undefined value (or something like
that, have been meaning to check). I can't recall now unfortunately. Would
seem its unnecessary now though.
On 6 Apr 2016 5:35 p.m., "Wesley Cho" [email protected] wrote:

Those tests currently pass without the changeset from the PR.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1529 (comment)

[user378230]

Will close for now, it looks a bit silly admittedly but there's no need to introduce unnecessary change at the risk of breaking something else. Maybe that section will refactored at some point in the future, anyway.

If anyone finds a need for this change please update with details and we can look at reopening this.