This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(select-choices): Possible fix for #1355 #1518
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...at the cost of potential unnecessary watches when dropdown is closed. But the premise is that, until the resulting errors are fixed, the preference is to avoid the errors for now. Closes angular-ui#1355
|
This has negative performance implications - it probably would be more ideal to figure out the root cause of the errors. |
|
OK; I just send it because it was mentioned as an ad hoc change in the thread for #1355 and users there were generally positive about it. The potential performance impact was a known compromise. I can look harder for the root cause then update the request. |
|
Latest upstream source tree appears to remove the original #1355 issue; closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...at the cost of potential unnecessary watches when dropdown is closed.
But the premise is that, until the resulting errors are fixed, the
preference is to avoid the errors for now.
Closes #1355