This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(parser) allow track by without filter #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2016 23:04
Previously the parser always attempted to extract a filter from the repeat expression, regardless of whether it was present or not. This resulted in the track by part of the expression being interpreted as a filter. This commit changes the parser regex to capture the entire object source, including its filters, before matching any track by expression. The filters are then extracted separately from the source as this step is only required when using an object as a source. Fixes angular-ui#1233
user378230
changed the title
aaronroberson
added a commit
that referenced
this pull request
Mar 6, 2016
fix(parser) allow track by without filter
|
This has landed in [email protected]. Thanks @user378230! |
This was referenced Mar 15, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow track by without filter
Simple repeat expressions that used track by failed.
The previous regex attempted to extract the filters from the expression but greedily included the track by portion too. The filters, however, are only needed when using an object as a source as
ui-selectneeds to manually apply them when converting the object to an array.Now the repeat parser will extract the source expression in one lump and let
$parsedeal with it if it can, only if an object source is used, will it attempt to extract the filters.This more closely aligns
ui-selectwithngOption's parsing/regex (though it doesn't need to extract any filters).Fixes #1233 #1462 #1263 #1270