This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Modified gulp tasks to generate sourcemaps for min.css and min.js #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilanar
force-pushed
the
gulp-sourcemaps
branch
from
116a596 to
f6a5b20
Compare
|
This needs rebasing - this seems like a useful feature though. |
|
OK, I'll work on rebasing which shouldn't be much trouble. |
anilanar
force-pushed
the
gulp-sourcemaps
branch
from
f6a5b20 to
0e9d715
Compare
anilanar
force-pushed
the
gulp-sourcemaps
branch
from
0e9d715 to
50d7e0d
Compare
|
@wesleycho Done rebasing, tested, seems to work fine. |
|
@aaronroberson the builds are your side of things so I'll leave this one to you 😃 |
|
This LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1107.
Additional Notes
gulp-renamedependency is removed because it didn't work well withgulp-sourcemapseven though it is supported.gulp-concatis used instead.gulp-concatto the latest version: So I needed to upgrade this due to a bug in previous versions.Alphabetically sorted dependencies inpackage.json, which is the default behaviour whennpm installis used with--saveor--save-dev.