This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Avoid inline execution of javascript in choices template. #1182
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
added a commit
to blockchain/My-Wallet-V3-Frontend
that referenced
this pull request
Sep 8, 2015
|
Is there something I should improve in this PR to make it more likely to get merged? |
dimirc
added a commit
that referenced
this pull request
Nov 1, 2015
Avoid inline execution of javascript in choices template.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a server sets the
content-security-policyheader toscript-src 'self' 'unsafe-inline';all works well, but withoutunsafe-unline, the browser will throw an error:Refused to execute JavaScript URL because it violates the following Content Security Policy directive:.There is no stack trace, but it turns out this is caused by
href="javascript:void(0)"in the choices template.Pull request #395 proposed removing that piece Javascript altogether, but apparently there were side effects.
I'm replacing it with
ng-click="$event.preventDefault()", based on a similar fix in the ui.bootstrap project. This makes the CSP error go away.All tests pass. I tried all examples in Safari and couldn't see anything obviously wrong, but I'm not sure what to look for.