Merge pull request #1571 from Teegrounet/perf-ctrl-isActive

user378230 · user378230 · commit bd7654dbe77c · 2016-04-25T12:36:32.000+01:00
perf(uiSelectCtrl): change test in ctrl.isActive
diff --git a/src/uiSelectController.js b/src/uiSelectController.js
@@ -306,7 +306,7 @@ uis.controller('uiSelectCtrl',
     var itemIndex = ctrl.items.indexOf(itemScope[ctrl.itemProperty]);
     var isActive =  itemIndex == ctrl.activeIndex;
 
-    if ( !isActive || ( itemIndex < 0 && ctrl.taggingLabel !== false ) ||( itemIndex < 0 && ctrl.taggingLabel === false) ) {
+    if ( !isActive || itemIndex < 0 ) {
       return false;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ uis.controller('uiSelectCtrl',`
`306`	`306`	`var itemIndex = ctrl.items.indexOf(itemScope[ctrl.itemProperty]);`
`307`	`307`	`var isActive = itemIndex == ctrl.activeIndex;`
`308`	`308`
`309`		`- if ( !isActive \|\| ( itemIndex < 0 && ctrl.taggingLabel !== false ) \|\|( itemIndex < 0 && ctrl.taggingLabel === false) ) {`
	`309`	`+ if ( !isActive \|\| itemIndex < 0 ) {`
`310`	`310`	`return false;`
`311`	`311`	`}`
`312`	`312`