perf: change test in ctrl.isActive

Teegrounet · Teegrounet · commit d6c14d436f8d · 2016-04-17T11:02:27.000+02:00
perf: change test in ctrl.isActive

before :
( itemIndex &lt; 0 &amp;&amp; ctrl.taggingLabel !== false ) ||( itemIndex &lt; 0 &amp;&amp; ctrl.taggingLabel === false)
after :
itemIndex &lt; 0
diff --git a/src/uiSelectController.js b/src/uiSelectController.js
@@ -287,7 +287,7 @@ uis.controller('uiSelectCtrl',
     var itemIndex = ctrl.items.indexOf(itemScope[ctrl.itemProperty]);
     var isActive =  itemIndex == ctrl.activeIndex;
 
-    if ( !isActive || ( itemIndex < 0 && ctrl.taggingLabel !== false ) ||( itemIndex < 0 && ctrl.taggingLabel === false) ) {
+    if ( !isActive || itemIndex < 0 ) {
       return false;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ uis.controller('uiSelectCtrl',`
`287`	`287`	`var itemIndex = ctrl.items.indexOf(itemScope[ctrl.itemProperty]);`
`288`	`288`	`var isActive = itemIndex == ctrl.activeIndex;`
`289`	`289`
`290`		`- if ( !isActive \|\| ( itemIndex < 0 && ctrl.taggingLabel !== false ) \|\|( itemIndex < 0 && ctrl.taggingLabel === false) ) {`
	`290`	`+ if ( !isActive \|\| itemIndex < 0 ) {`
`291`	`291`	`return false;`
`292`	`292`	`}`
`293`	`293`