Fix top visible scrolling #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. We have researched a problem and made a decision to fix it in a minimal way: just two lines of code which are pretty enough to let topVisible property to be recalculated during scrolling without fetching. Note that $scope.$apply runs digest cycle only for scroller scope while $timeout forces digest for all available scopes in the App... May it is a good time to think about other $timeout's optimization? Also I've added a group of 4 tests on topVisible property. The last test fails without this fix. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #70. This changes only one test to allow for the adding of $timeout to the calculateProperties function.