Not destroying invisible list elements when using without ui-scroll-viewport

[moosi]

I am currently facing the problem that ui-scroll is not working as expected if I don't use a fixed height with ui-scroll-viewport.

I am using the plugin for different feeds in my app. For example:

--- Top Nav ---
--- Feed ---
--- Bottom Nav ---

or

--- Top Nav ---
--- User Profile ---
--- User Feed ---
--- Bottom Nav ---

Because of this setup I need a dynamic list height. After removing ui-scroll-viewport my posts are loaded as expected when I scroll down but the DOM is growing and growing without destorying the invisible elements.

I am using version 1.3.3 with angular 1.3.2. Is there any solution for my problem?

[mfeingold]

Can you post a repro for your problem?

Michael Feingold, President
401 Huehl RD, Suite 2A,
Northbrook, IL 60062
Email: [email protected]
Web: hill30.com http://www.hill30.com

On Sat, Apr 2, 2016 at 1:31 PM, moosi [email protected] wrote:

I am currently facing the problem that ui-scroll is not working as
expected if I don't use a fixed height with ui-scroll-viewport.

I am using the plugin in different views of my app. For example:

--- Top Nav ---
--- Feed ---
--- Bottom Nav ---

or

--- Top Nav ---
--- User Profile ---
--- User Feed ---
--- Bottom Nav ---

Because of this setup I need a dynamic list height. After removing
ui-scroll-viewport my posts are loaded as expected when I scroll down but
the DOM is growing and growing without destorying the invisible elements.

I am using version 1.3.3 with angular 1.3.2. Is there any solution for my
problem?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#78

[moosi]

Thank you for your fast response. I created a demo for you:

https://plnkr.co/edit/OzsoQUm0Vw8bDgoDN8ro?p=preview

[tsabbay]

+1
same is happening in our code.

[dhilt]

It defenetly can be reproduced on our Entire window scrollable demo. And the bad news is that this demo does not work for a long time. As I remember about 20 days ago we did some fix related to this demo (cause it was totally broken) but we did not check removing from DOM after this... Thanks @moosi.

I see that during scrolling down every item in the buffer has positive offset().top and
buffer[i+1].element.offset().top > buffer[i].element.offset().top
while viewportOffset().top = 0 cause we have no viewport
so clipTop() which has to remove "invisible" elements does not work.

We need to take care of this.

[dhilt]

I solved the issue by clipTop/clipBottom refactoring. Now these pieces of logic are really unified and transparent. The code is in master and will be included in 1.4.1 release soon.

[moosi]

Thank you so much for the fast implementation! First tests were successful :)

[dhilt]

Fixed in v1.4.1.