migrate sample app to a more 'best practice' directory layout #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job. Please update the commit message to reflect the contributor guidelines, and I'll get this merged. |
The current example is a bit too simplistic in my experience to fully grasp the power of ui-router. It provides a monolithic example of state definition that shows the varied approaches that can be used, but not in a very structured format. This change applies the emerging best practice directory layout of an angular application to exemplify the power of ui-router
|
updated |
|
@nateabele also, what up philly ;) |
|
Hey hey! |
nateabele
added a commit
that referenced
this pull request
Mar 13, 2014
migrate sample app to a more 'best practice' directory layout
|
Hell yeah, thanks @mbroadst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat invasive change, but I feel like it provides a few benefits:
Please let me know what you think, or how I can improve upon this design. This was created as more of a thought experiment of applying the patterns described in the wiki to my own project, so I may have missed something.