feat(UrlMatcher): Add support for case insensitive url matching

[mauroservienti]

Add support for case insensitive url matching, by default url match is case sensitive, for backward compatibility. Case sensitive match can be turned on/off globally via $urlMatcherFactoryProvider caseInsensitiveMatch( true/false ) method.

[timkindberg]

You did it!!

[christopherthielen]

thanks 👍 @mauroservienti

[mauroservienti]

my pleasure :-)
A question: any plan for a 0.2.9 release that includes this and the fixes for #919 and #858?

cheers,
.m

[christopherthielen]

@mauroservienti Tim commented on #704 (comment) 5 days ago saying the next release would be something like 4 weeks out.

[mauroservienti]

great, thanks again.

[nateabele]

Sorry I didn't get a chance to comment on this, but I really wish it hadn't been merged. :-/

This is really bad API design, and it'll be that much more problematic for people using it when it gets cleaned up.

[mauroservienti]

What is the problem with the API, there is one single method, and nothing else?

[timkindberg]

@nateabele sorry, I'll not merge things in the future without your comment. It seemed like the appropriate API to me though. My bad man. How do you think we should have approached it?

[nateabele]

@mauroservienti Most of the problems are around the new constructor signature for UrlMatcher. (A) When a method accepts multiple parameters, boolean parameters are bad because you can't infer their meaning from context. (B) This sets the precedent that every new configuration option will be yet-another-parameter.

[mauroservienti]

Really good point, thanks for the explanation. I'm not so good at JavaScript.
Since we are still in time, how do you suggest we change the implementation?
Maybe via a factory method or a property even on the UrlMatcher?

Cheers.
.m

---

From: Nate Abelemailto:[email protected]
Sent: ý15/ý03/ý2014 16.54
To: angular-ui/ui-routermailto:[email protected]
Cc: Mauro Servientimailto:[email protected]
Subject: Re: [ui-router] feat(UrlMatcher): Add support for case insensitive url matching (#957)

@mauroservientihttps://github.com/mauroservienti Most of the problems are around the new constructor signature for UrlMatcher. (A) When a method accepts multiple parameters, boolean parameters are bad because you can't infer their meaning from context. (B) This sets the precedent that every new configuration option will be yet-another-parameter.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/957#issuecomment-37729311.

[timkindberg]

So maybe we should have done an options param instead as the 2nd parameter. So then it would be explicit: {caseInsensitive: true/false}