Skip to content

test(uiView): Added in tests for ngClass, ngRepeat, and animations. #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2014

Conversation

meenie
Copy link
Contributor

@meenie meenie commented Mar 6, 2014

Adding in some missing tests for the new functionality brought in by #858. You will notice that I've skipped doing animation testing for 1.0.8 and 1.1.5. Technically 1.1.5 does handle animations, but since it's unstable, what's the point of writing tests for that. So I would recommend that anyone wanting to do animations with uiRouter they use Angular 1.2+

@timkindberg
Copy link
Contributor

@meenie
Copy link
Contributor Author

meenie commented Mar 6, 2014

@timkindberg - Yes, both are good examples. I noticed that with current the release version of uiRouter the 1.1.5 example doesn't work. I swapped it out with the #858 version of uiRouter and it works :). It does do some weird box collapse visual, but I think that can be fixed with CSS.

@meenie
Copy link
Contributor Author

meenie commented Mar 7, 2014

Anyone have issues with the tests I wrote? If not, I'll merge in a little while.

meenie added a commit that referenced this pull request Mar 7, 2014
test(uiView): Added in tests for ngClass, ngRepeat, and animations.
@meenie meenie merged commit e3ba1bf into angular-ui:master Mar 7, 2014
@meenie meenie deleted the tests/uiView branch March 7, 2014 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants