feat(uiSref): extend syntax for ui-sref #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it 👍 |
|
Oh you are missing docs for it though, would you mind adding a blurb in the ngdoc comment? |
|
@timkindberg yes, sure |
|
Yeah, I'm down. As @timkindberg says, docs. Also, |
timfjord
changed the title
add possibility to pass params to current state without entering state name
|
@timkindberg @nateabele i have updated docs and commit message |
|
Looks good! |
|
^:five:! |
nateabele
added a commit
that referenced
this pull request
Mar 18, 2014
feat(uiSref): extend syntax for ui-sref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to pass params to current state without entering state name
For example, if current state is
details, so<a ui-sref="{id: 5}">Details</a>is a syntax sugar for<a ui-sref="details({id: 5})">Details</a>