fix($state.go): param inheritance shouldn't inherit from siblings #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in the ancestors() function, we were treating any states at the same depth from root as "ancestors". This means siblings were inheriting parameters from each other. Interestingly ui-sref generated the correct links, but the click handler then broke the link. Unfortunately this is a breaking change if someone depends on the broken behavior of inheriting all the params on sibling state transitions. The fix for these folks is mostly simple: create a common parent state that contains parameters that need to be shared. Unfortunately it can introduce quite a bit of churn in the codebase.
nateabele
added a commit
that referenced
this pull request
Dec 27, 2013
fix($state.go): param inheritance shouldn't inherit from siblings
|
We're still pre-1.0, so I don't mind sacrificing some BC for correctness. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the ancestors() function, we were treating any states at the same depth from root as "ancestors". This means siblings were inheriting parameters from each other. Interestingly ui-sref generated the correct links, but the click handler then broke the link.
Unfortunately this is a breaking change if someone depends on the broken behavior of inheriting all the params on sibling state transitions. The fix for these folks is mostly simple: create a common parent state that contains parameters that need to be shared. Unfortunately it can introduce quite a bit of churn in the codebase.