Allow state options to be overidden in ui-sref directive

[IcanDivideBy0]

Options passed to the $state.go() and $state.href() cannot be changed while using the ui-sref directive.

[caitp]

hmm, I can see that it's flexible, but hmmm... I'm not sure how I feel about this

[IcanDivideBy0]

Since params are parsed with a regex, we cannot add options in the same place ... I can see only two options :

• stop using regex to parse prams and add options in ui-sref directive
• using the ui-sref-opts attribute proposed here

Anyways, I think that using regex for this kind of stuff is the wrong way to go.

[timkindberg]

This has actually already been brought up and rejected in a different pull request, but this is a different approach. This approach matches what @nateabele had mentioned was his idea for implementation in his last comment. See #644.

I think I'm ok with this enhancement. @nateabele?

[campersau]

Typo: overiden => overridden

[nateabele]

Finally following up on this... I can definitely see some jankyness happening if people are able to arbitrarily overwrite any go() option (i.e. since some of them are calculated). I think at a minimum we should lock it down to whatever options you'd actually want to change. IMO location, inherit, and reload are probably enough. @caitp is that about what you were thinking?

[caitp]

That's the gist of it... If there are specific options supported, it seems less harmful. One thing I don't necessarily want is another $watch, this should probably be evaluated only at link-time.

Anyways, it's just my opinion :>

[nateabele]

Well, at worst I guess we could $watch the union of this and ui-sref, right?

[roryf]

Any update on this being merged? If there's changes to be made, I can jump in.

[nateabele]

Any update on this being merged? If there's changes to be made, I can jump in.

@roryf Yeah, could you? Here's what's outstanding:

• Needs to be rebased, since HEAD has diverged
• Needs to be brought into line with contributor guidelines
• Needs to respect restrictions discussed above

Please feel free to fire off any questions you might have.

[nateabele]

Implemented in #813.

[timkindberg]

This makes me feel like we should have done ui-sref-params as a separate directive too, instead of coming up with our own string syntax there.