Skip to content

docs(state): wip documentation for state service #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 16, 2013

Conversation

0x-r4bbit
Copy link
Contributor

No description provided.

@0x-r4bbit
Copy link
Contributor Author

The new PR (@nateabele please do not merge it! :D) for work in progress API documentation.

@0x-r4bbit
Copy link
Contributor Author

Allright @nateabele @timkindberg This is how it currently looks like http://pascalprecht.github.io/ui-router/#/api Next step would be to write a developer guide. And then improve the api docs with more examples. What do you say?

@0x-r4bbit
Copy link
Contributor Author

BTW @nateabele you can merge these now, haha.

@timkindberg
Copy link
Contributor

You are so awesome @PascalPrecht!

Some things I notice we'll still need, obviously we'll get to these, but thought it would be good to make notes while I had time.

  • compat module should be last, or if we can't make it last, maybe remove it. Just gonna confuse people, I know it.
  • if we do keep compat, then $routeProvider is missing docs e.g. when()
  • Missing UrlMatcher docs
  • Can we add versioning to each item's doc?
  • How/where will we document the go and transitionTo options?

Once it's merged, I'm happy to review in depth and fix any little errors/errata.

@0x-r4bbit
Copy link
Contributor Author

@timkindberg It's just a work in progress, so yea I'll add the docs for $routeProvider sorry for missing them. It should be clear that the docs you're seeing now are only API docs. Which means, a lot of stuff from the current wiki don't necessarily need to be in the API docs, since they would be better placed in a Developer Guide (example: http://pascalprecht.github.io/angular-translate/docs/en/#/guide). The developer guide will be more a kind of book which you can read through to understand step by step how to use UI-Router. This could also be the place to document the go and transitionTo options, but I'd prefer them in the API docs.

What do you mean with add versioning to each item doc? The API docs are versioned through source code. The developer doc will be a folder with .ngdoc files. example( https://github.com/PascalPrecht/angular-translate/tree/master/docs/content/guide/en ). These documents are (for sure) also versioned.

@0x-r4bbit
Copy link
Contributor Author

@timkindberg btw: great you like it :)

nateabele added a commit that referenced this pull request Dec 16, 2013
docs(state): wip documentation for state service
@nateabele nateabele merged commit c985f25 into angular-ui:master Dec 16, 2013
@0x-r4bbit 0x-r4bbit deleted the ngdocs branch December 16, 2013 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants