Skip to content

feat(stateDirectives): specify options in ui-sref for $state calls #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat(stateDirectives): specify options in ui-sref for $state calls #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8ca36a
feat(stateDirectives): specify options in ui-sref for $state calls
mfield Dec 6, 2013
d80442f
Perhaps it's not all sunshine and rainbows.
mfield Dec 6, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 30 additions & 27 deletions src/stateDirectives.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
function parseStateRef(ref) {
var parsed = ref.replace(/\n/g, " ").match(/^([^(]+?)\s*(\((.*)\))?$/);
if (!parsed || parsed.length !== 4) throw new Error("Invalid state ref '" + ref + "'");
return { state: parsed[1], paramExpr: parsed[3] || null };
var parsed = ref.replace(/\n/g, " ").match(/^([^(]+?)\s*(\(.*\))?\s*$/);
if (!parsed || parsed.length !== 3) throw new Error("Invalid state ref '" + ref + "'");

var state = parsed[1],
paramExpr = parsed[2];
return '["' + state + '"].concat' + (paramExpr || '()');
}

function stateContext(el) {
Expand All @@ -18,43 +21,43 @@ function $StateRefDirective($state) {
restrict: 'A',
require: '?^uiSrefActive',
link: function(scope, element, attrs, uiSrefActive) {
var ref = parseStateRef(attrs.uiSref);
var params = null, url = null, base = stateContext(element) || $state.$current;
var isForm = element[0].nodeName === "FORM";
var attr = isForm ? "action" : "href", nav = true;

var update = function(newVal) {
if (newVal) params = newVal;
if (!nav) return;
var ref = parseStateRef(attrs.uiSref),
params = [],
base = stateContext(element) || $state.$current,
isForm = element[0].nodeName === "FORM",
attr = isForm ? "action" : "href";

var defaults = {
relative: base
};

var newHref = $state.href(ref.state, params, { relative: base });
var update = function(newParams) {
params = [].concat(newParams);
params[1] = params[1] || {};
params[2] = angular.extend({}, defaults, params[2] || {});

var newHref = $state.href.apply($state, params);
if (!newHref) {
nav = false;
return false;
return;
}
element[0][attr] = newHref;

attrs.$set(attr, newHref);

if (uiSrefActive) {
uiSrefActive.$$setStateInfo(ref.state, params);
uiSrefActive.$$setStateInfo.apply(uiSrefActive, params);
}
};

if (ref.paramExpr) {
scope.$watch(ref.paramExpr, function(newVal, oldVal) {
if (newVal !== params) update(newVal);
}, true);
params = scope.$eval(ref.paramExpr);
}
update();
scope.$watch(ref, update, true);

if (isForm) return;

element.bind("click", function(e) {
var button = e.which || e.button;

if ((button === 0 || button == 1) && !e.ctrlKey && !e.metaKey && !e.shiftKey) {
if ((button === 0 || button === 1) && !e.ctrlKey && !e.metaKey && !e.shiftKey) {
scope.$evalAsync(function() {
$state.go(ref.state, params, { relative: base });
$state.go.apply($state, params);
});
e.preventDefault();
}
Expand All @@ -74,8 +77,8 @@ function $StateActiveDirective($state, $stateParams, $interpolate) {
activeClass = $interpolate($attrs.uiSrefActive || '', false)($scope);

// Allow uiSref to communicate with uiSrefActive
this.$$setStateInfo = function(newState, newParams) {
state = $state.get(newState, stateContext($element));
this.$$setStateInfo = function(newState, newParams, options) {
state = $state.get(newState, options.relative || stateContext($element));
params = newParams;
update();
};
Expand Down
66 changes: 66 additions & 0 deletions test/stateDirectivesSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,72 @@ describe('uiStateRef', function() {
expect($state.current.name).toEqual('');
expect($stateParams).toEqual({ id: "5" });
}));

it('should call $state.href with the provided options', inject(function($compile, $rootScope) {
el = angular.element('<a ui-sref="contacts.item.detail({id: $index}, {absolute: true})">Details</a>');
$rootScope.$index = 3;
$rootScope.$apply();

$compile(el)($rootScope);
$rootScope.$digest();
expect(el.attr('href')).toBe('http://server/#/contacts/3');
}));

it('should call $state.href with the provided options when parameters change', inject(function($compile, $rootScope) {
el = angular.element('<a ui-sref="contacts.item.detail({id: $index}, myOptions)">Details</a>');
$rootScope.$index = 3;
$rootScope.$apply();

$compile(el)($rootScope);
$rootScope.$digest();
expect(el.attr('href')).toBe('#/contacts/3');

$rootScope.myOptions = {absolute: true}
$rootScope.$digest();
expect(el.attr('href')).toBe('http://server/#/contacts/3');
}));

it('should call $state.go with the provided options', inject(function($compile, $rootScope) {
el = angular.element('<a ui-sref="contacts.item.detail({id: 3}, {notify: shouldNotify})">Details</a>');
$compile(el)($rootScope);
$rootScope.shouldNotify = true;
$rootScope.$digest();

$rootScope.$on('$stateChangeStart', function(event) {
expect($rootScope.shouldNotify).toBe(true);
event.preventDefault();
});

triggerClick(el);
$rootScope.$digest();

$rootScope.shouldNotify = false;
$rootScope.$digest();

triggerClick(el);
$rootScope.$digest();
}));

it('can be used for evil', inject(function($compile, $rootScope) {
$rootScope.doEvil = function() {
throw Error('doing some evil');
}

el = angular.element('<a ui-sref="foo(); doEvil()">Details</a>');
$compile(el)($rootScope);
expect($rootScope.$digest).toThrow();
}));

it('actually fixes #395, if you are a terrible human being', inject(function($compile, $rootScope) {
el = angular.element('<a ui-sref="dynamic(stateName, stateParams, stateOptions).slice(1)">Details</a>');
$compile(el)($rootScope);

$rootScope.stateName = 'contacts.item.detail';
$rootScope.stateParams = {id: 3};

$rootScope.$digest();
expect(el.attr('href')).toBe('#/contacts/3');
}));
});

describe('forms', function() {
Expand Down