Make .href() support .hashPrefix() #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateabele
added a commit
that referenced
this pull request
Nov 6, 2013
Make .href() support .hashPrefix()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google's AJAX crawling protocol requires a #! root instead of just at #. This is easy to accomplish using $locationProvider.hashPrefix("!"); however, ui-router's $state.href does not currently check the hash prefix.
To improve upon this commit, consider stashing the hash prefix just outside of $state.href's closure. That would be nice from a performance standpoint. I did not do that myself because hashPrefix would have to be set before ui-router is injected, and I'm not familiar enough with ui-router's codebase to understand the fix.