Common JS package manager support breaks ui-router in browsers #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Kryuchkov <[email protected]>
nateabele
added a commit
that referenced
this pull request
Oct 1, 2013
Common JS package manager support breaks ui-router in browsers
|
Sorry about this, its my mistake, and thanks for the fix @xelibrion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get the Uncaught ReferenceError: module is not defined exception in Chrome and Firefox. The pull request fixes this problem.
It probably would be a good idea to run tests against the combined file, but it would require a substantial amount of work as quite a few of them currently fail if you make karma to run tests against build/angular-ui-router.js.