Skip to content

fix(docs): Update 'ui.router' to 'ui.state' and a typo in an example #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2013
Merged

fix(docs): Update 'ui.router' to 'ui.state' and a typo in an example #331

merged 1 commit into from
Aug 18, 2013

Conversation

Foxandxss
Copy link
Contributor

No description provided.

nateabele added a commit that referenced this pull request Aug 18, 2013
fix(docs): Update 'ui.router' to 'ui.state' and a typo in an example
@nateabele nateabele merged commit 92388f8 into angular-ui:master Aug 18, 2013
@timkindberg
Copy link
Contributor

It's supposed to be ui.router though. Depends if we want the quick start to reflect stable or latest.

@nateabele
Copy link
Contributor

Oh, my bad. I totally misread that. I was chatting with @Foxandxss in IRC and thought I correctly explained how we renamed the module, so I just assumed it was correct.

@Foxandxss
Copy link
Contributor Author

Since the README says that the doc is for 0.0.2 I guess that ui.state is the way to go.

@nateabele You said me to change it too! :P

@Foxandxss Foxandxss deleted the patch-1 branch August 18, 2013 22:44
@timkindberg
Copy link
Contributor

Since the README says that the doc is for 0.0.2 I guess that ui.state is the way to go.

Actually if we want the docs to reflect 0.0.2 it needs to be ui.router. If 0.0.1, ui.state. I'm ok with either, confusion will happen either way.

@nateabele
Copy link
Contributor

Let's go with 0.0.2.

@nateabele
Copy link
Contributor

@Foxandxss Yeah I know, I misunderstood you. My fault.

@Foxandxss
Copy link
Contributor Author

I see, it was a double confusion then. I thought that the new was ui.state and not ui.router (Was my first but not last try out of ui-router).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants