doc(UrlMatcher): RegExp and string encoding interaction
#3050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added some documentation about how the tilde encoding interacts with RegExp params. It seemed to only exist in tickets and the code.
My thoughts are that there's no way to fix it so that you wouldn't need to know about the encoding, because there needs to be a way to match both real slashes and encoded slashes.
This makes the RegExp param description quite long, but I couldn't find a better place to put it.
I've also created a branch that ports the change to legacy.
I think this should be enough to close #2540.