Skip to content

Use ReflectorReader to get inputs (fixes #3007) #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

ValentinFunk
Copy link
Contributor

It's imported like this in @angular/compiler as well.

Was going to mark it injectable as in https://github.com/angular/angular/blob/42a287fabf6b035d51e00cf3006c27fec00f054a/modules/%40angular/compiler/src/ng_module_resolver.ts but unfortunately not all platforms (namely browser-dynamic) provide it.

@ValentinFunk
Copy link
Contributor Author

Sorry, does NOT fix #3007, but does fix #3006

@christopherthielen
Copy link
Contributor

Hey thanks for this PR.

I'm reworking the NgModule support + config/bootstrapping. We'll be dropping the @UIRouterModule decorator in favor of router v3-like UIRouterModule.forRoot({ states }) and UIRouterModule.forChild({ states }) factory functions (even though I really hate that convention). My original @UIRouterModule decorator pattern is not compatible with AoT compile.

After those changes land, I'll take a closer look at this PR

@christopherthielen christopherthielen added this to the 1.0.0-final milestone Sep 21, 2016
@christopherthielen christopherthielen merged commit e090fde into angular-ui:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants