Made ui-router noImplicitAny compliant #2836
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #2693.
I know the issue had been marked as WontFix but i've created this PR given that users of the latest router will have to be on TypeScript 2.0 (which hasn't yet shipped) and have specific a tsconfig option set in order to use the ui-router (usage of
noImplicitAny
is pretty commonplace). That's a real shame and a slight barrier to entry.For the most part it was just a case of taking a trip through the code and adding to method signatures an
any
annotation per parameter where there is no annotation at all at present. If you decided to upgrade the types to something more specific over time that would be completely open to you.Whilst working on this I noticed there were some invalid references to the
stateEvents.ts
file infiles.js
andGruntfile.js
. I've fixed these so they point to thelegacy
subfolder.