refactor(view): refactor how views are loaded and configured. #2619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Require a Framework-specific (ng1/ng2) StateBuilder `views` decorator
- The `views` decorator takes `ViewDeclaration`s and returns normalized `ViewDeclaration`s
- Before a `Transition` begins, a `ViewConfig` is created and bound to the appropriate Node
- During the transition, the `ViewConfig` is prepped using `load()`
- After the configs are prepped, they are registered with the `StateService`, to be matched with `ui-view`s
- The `$element.data('$uiView')` is reorganized and simplified.
- $element.data('$uiView').$uiView has the ActiveUIView object
- $element.data('$uiView').$cfg has the ViewConfig object
| @@ -158,6 +158,11 @@ function ng1UIRouter($locationProvider) { | |||
|
|
|||
| // Create a new instance of the Router when the ng1UIRouterProvider is initialized | |||
| router = new UIRouter(); | |||
|
|
|||
| // Apply ng1 `views` builder to the StateBuilder | |||
| router.stateRegistry.decorator("views", ng1ViewsBuilder); | |||
There was a problem hiding this comment.
Register the ng1 views "StateBuilder decorator".
christopherthielen
added a commit
that referenced
this pull request
Mar 17, 2016
refactor(view): refactor how views are loaded and configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StateBuilderviewsdecorator that understand different keys/values to meet that framework's needsviewsdecorator takesViewDeclarations (theviewsblock on the state declaration), and processes them. It returns normalized framework specific POJOs (i.e.Ng1ViewDeclarations)Transitionbegins, each normalizedViewDeclarationbeing activated is converted into aViewConfigand added to theNode'sviewsarrayViewServiceis responsible for creating an instance of aViewConfigfrom theViewDeclaration, based on the type ofViewDeclaration(registered usingViewService.viewConfigFactory)ViewConfigis prepped (load templates, controllers, components) usingviewConfig.load()StateService(to be matched withui-views)$element.data('$uiView')is reorganized and simplified.ActiveUIViewref object (formerly namedUiViewData)ViewConfigref object