fix(transitionTo): re-added the saved hash before broadcasting event #2464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, the patch makes sense. We just need a matching unit test to prevent regressions. |
|
So, the idea is you want to have a unit test that fails against master but passes with your patch. In this case, that means asserting that the hash is available in a |
|
Test looks good. Almost there: http://prjs.radify.io/#/angular-ui/ui-router/pulls/2464 |
blokfyuh
force-pushed
the
blokfyuh-hash-fix-permissions-plugins
branch
from
c1096e1 to
a2ede2c
Compare
|
The subject looks good, the commits have been squashed. Do I pass ? :D |
|
Almost! It's the subject of the commit, not the PR. Sorry about that. I'm gonna fix the language in the UI so it's clearer. |
Re-added the saved hash before broadcasting $stateChangeStart. This way, libraries using this event to do their magic will have the hash accessible through toParams. (e.g. https://github.com/Narzerus/angular-permission)
blokfyuh
force-pushed
the
blokfyuh-hash-fix-permissions-plugins
branch
from
a2ede2c to
8c1bf30
Compare
|
No problem. Let me know if we are good this time. |
|
Yesssss! |
nateabele
added a commit
that referenced
this pull request
Jan 19, 2016
…plugins fix(transitionTo): re-added the saved hash before broadcasting event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-added the saved hash before broadcasting $stateChangeStart. This way, libraries using this event to do their magic will have the hash accessible through toParams. (e.g. https://github.com/Narzerus/angular-permission)
Thoughts/comments ?