provide resolved dependencies to the $stateChangeSuccess event #229
Conversation
|
We're currently working on providing these events with much more data (which will include resolved locals), so I don't think we want to change the API twice. |
this commit adds toLocals and fromLocals parameters to the $stateChangeSuccess event similar to the "locals" property for the parameters on the $routeChangeSuccess event on angular core.
|
Hey @nateabele I update this ancient PR to work against latest master again. It's probably not ready for merging but I didn't want to put too much effort into it before I received any positive signal from you. I think the claim is still valid: the vanilla angular I'd really like the ui-router to behave more like Angulars built in routing in this case and I guess other might run into this issue, too. With this PR I'm exposing a bit too much I guess and it's also missing tests so I completely understand it's not ready for merge yet but if you agree with me that we want this and leave some advice on the implementation, I'd be happy to work on that. |
|
@cburgdorf so the plan is to implement a $transition service that holds data for any currently running transition (or null if there isn't one). This would then be injected into the various event handlers instead of the many params. The params would be moved onto the $transition service as properties. I'm not sure on the status of this work though, so @nateabele would have to tell you if its worth it for you to workon. |
|
Yeah, please follow #1257 for the implementation of this, as we're taking a much cleaner approach to solve the problem. |
This commit adds a property
localsto the state parameters of the$stateChangeSuccessevent similar to thelocalsproperty for the parameters on the$routeChangeSuccessevent on angular core.Fixes #228