Skip to content

fix(urlMatcherFactory): Slashes are now properly decoded in url params #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ckniffen
Copy link

Fixes: #1973, #1645

@piotrd
Copy link

piotrd commented Jul 1, 2015

👍 tested with a large app, works great. Can anyone merge it, please?

@ckniffen
Copy link
Author

ckniffen commented Jul 1, 2015

@piotrd have you checked #2071? I think it is a better implementation.

@piotrd
Copy link

piotrd commented Jul 2, 2015

@ckniffen: you're right. Thanks for pointing this one out, I somehow didn't notice that PR. I tested it now and unfortunately it fails for val being null. I made a comment in the PR about it, along with proposed improvement (https://github.com/angular-ui/ui-router/pull/2071/files#r33758421).

@ckniffen, btw, both PRs leave me with %252F in the address bar after navigating. I'm wondering if there's a way to avoid that and keep the original slash there. Or maybe it's a matter of my code. Will investigate further for sure.

@ckniffen
Copy link
Author

ckniffen commented Jul 2, 2015

Closing in favor of #2071.

@piotrd I get that too. I could not find a way around it though.

@ckniffen ckniffen closed this Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slashes are double encoded in hash query params
2 participants