Skip to content

refactor(commonjs): Added support for commonjs #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2015

Conversation

aaronroberson
Copy link
Contributor

Added ui.router to module exports so that after installing via npm, the package can be required in the angular module dependency list such as:

angular.module('myApp', [require('angular-ui-router')]);

This is helpful for Browserify and Webpack.

@nateabele
Copy link
Contributor

Patch looks fine. Please fix the PR per https://radify.github.io/PR.js/#/angular-ui/ui-router/pulls/1960 -- thanks.

@aaronroberson aaronroberson changed the title Added support for Browserify/Webpack chore: Added support for Browserify/Webpack May 19, 2015
@aaronroberson aaronroberson changed the title chore: Added support for Browserify/Webpack chore(commonjs): Added support for Browserify/Webpack May 19, 2015
@aaronroberson aaronroberson changed the title chore(commonjs): Added support for Browserify/Webpack chore(commonjs): Added support for commonjs May 19, 2015
@aaronroberson
Copy link
Contributor Author

I've update the PR to reflect the requirements but it is not updating in radify. Am I missing something?

@aaronroberson aaronroberson changed the title chore(commonjs): Added support for commonjs refactor(commonjs): Added support for commonjs May 19, 2015
@aaronroberson
Copy link
Contributor Author

@nateabele: I forgot to tag you in my response.

@christopherthielen
Copy link
Contributor

@aaronroberson it's the subject of the commit, not the PR

@aaronroberson
Copy link
Contributor Author

How do I change that?

On Tue, May 19, 2015, 6:26 PM Chris Thielen [email protected]
wrote:

@aaronroberson https://github.com/aaronroberson it's the subject of the
commit, not the PR


Reply to this email directly or view it on GitHub
#1960 (comment)
.

@nateabele
Copy link
Contributor

You need to fix the commit message itself. I think git commit --amend -m "refactor(package): Added support for commonjs"; git push -f.

@aaronroberson
Copy link
Contributor Author

Worked like a charm, thank you! I wasn't aware of the --amend flag until
now :D

On Wed, May 20, 2015 at 8:44 AM Nate Abele [email protected] wrote:

You need to fix the commit message itself. I think git commit --amend -m
"refactor(package): Added support for commonjs"; git push -f.


Reply to this email directly or view it on GitHub
#1960 (comment)
.

@nateabele
Copy link
Contributor

@aaronroberson Awesome. Glad I could help with your new thing learned today. 😄

nateabele added a commit that referenced this pull request May 20, 2015
refactor(commonjs): Added support for commonjs
@nateabele nateabele merged commit 91dfb70 into angular-ui:master May 20, 2015
@angular-ui angular-ui deleted a comment from aaronroberson Apr 1, 2019
@angular-ui angular-ui deleted a comment from aaronroberson Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants