-
Notifications
You must be signed in to change notification settings - Fork 3k
refactor(commonjs): Added support for commonjs #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Patch looks fine. Please fix the PR per https://radify.github.io/PR.js/#/angular-ui/ui-router/pulls/1960 -- thanks. |
I've update the PR to reflect the requirements but it is not updating in radify. Am I missing something? |
@nateabele: I forgot to tag you in my response. |
@aaronroberson it's the subject of the commit, not the PR |
How do I change that? On Tue, May 19, 2015, 6:26 PM Chris Thielen [email protected]
|
You need to fix the commit message itself. I think |
Worked like a charm, thank you! I wasn't aware of the On Wed, May 20, 2015 at 8:44 AM Nate Abele [email protected] wrote:
|
@aaronroberson Awesome. Glad I could help with your new thing learned today. 😄 |
refactor(commonjs): Added support for commonjs
Added
ui.router
to module exports so that after installing via npm, the package can be required in the angular module dependency list such as:angular.module('myApp', [require('angular-ui-router')]);
This is helpful for Browserify and Webpack.