fix($state) The is check on type any will always return true.
#1944
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -623,7 +623,7 @@ function $UrlMatcherFactory() { | |||
| any: { // does not encode/decode | |||
| encode: angular.identity, | |||
| decode: angular.identity, | |||
| is: angular.identity, | |||
| is: function(){ return true; }, | |||
There was a problem hiding this comment.
a function that always returns true?
There was a problem hiding this comment.
@eddiemonge The reason for this is that any.is was always returning whatever you passed in.
any.is(false) would always return false. Since everything is type any it should always return true.
|
Yeah, looks good. Throw in Strictly speaking, the test should probably go against the spec for |
ckniffen
force-pushed
the
bugfix/any-is-check
branch
2 times, most recently
from
4e2b221 to
aa9ebe0
Compare
|
You changed the commit message style so it doesnt follow angular guidelines anymore |
By not specifying an `is` method the default is method for types which always returns `true` will be used. Fixes breaking change in 0.2.14 where parameters no longer were allowed to have default values of `0`, `false`, `''`, `undefined`, or `-1`. Fixes: angular-ui#1915
ckniffen
force-pushed
the
bugfix/any-is-check
branch
from
aa9ebe0 to
ba6ed61
Compare
|
@eddiemonge Sorry about that. I have updated the message. |
nateabele
added a commit
that referenced
this pull request
May 9, 2015
fix($state) The `is` check on type `any` will always return true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes breaking change in 0.2.14 where parameters no longer were allowed to have default values of
0,false,'', orundefined.Fixes: #1915