feat(uiSrefActive): Added support for multiple nested uiSref directives #1613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed, but looks like it's not my fault. |
|
Mine is failing too, issues with semicolons (not our changes). |
|
Do |
|
Done. |
|
I've rebased the PR against the latest changes |
|
Patch looks great, well done. Thanks for your work on this. |
nateabele
added a commit
that referenced
this pull request
Apr 8, 2015
feat(uiSrefActive): Added support for multiple nested uiSref directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
uiSrefActivewill add active class if match any state of nesteduiSrefdirectives.