update(objectKeys): replace iterator for consistency #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We explicitly don't want that. See here: https://github.com/apetrosian/ui-router/blob/master/src/common.js#L10 |
|
@nateabele thats exactly why I proposed to replace |
|
Sorry, my bad for reviewing PRs half-asleep. Please update the commit message to comply with the contributor guidelines and I'll merge this. Thanks for your patience, and sorry about the misunderstanding. |
apetrosian
changed the title
apetrosian
changed the title
apetrosian
changed the title
apetrosian
changed the title
|
@nateabele No problem, seems commit message was updated correctly. |
nateabele
added a commit
that referenced
this pull request
Dec 20, 2014
update(objectKeys): replace iterator for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced
angular.forEachtoforEach, that defined on top of common module.