fix($state): populate default params in .transitionTo. closes #1396 #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix($urlMatcherFactory): get Param's Type from config or url
fix($urlMatcherFactory): fix shorthand param values - simplify param config code.
|
@nateabele I added a Param class in Ignore the excess commits, I left them there in case it might be easier to merge into |
| type: type, | ||
| config: config, | ||
| dynamic: undefined, | ||
| isOptional: defaultValueConfig.value !== undefined, |
There was a problem hiding this comment.
I'm not yet satisfied with this logic. this means paramName: undefined is not optional but paramName: null is optional
|
Also, FYI I'm looking for a design review of Param class as opposed to a PR review. |
|
closing in lieu of #1443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.