Skip to content

feat($state): is/includes/get work on relative stateOrName #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2014
Merged

feat($state): is/includes/get work on relative stateOrName #1371

merged 1 commit into from
Sep 15, 2014

Conversation

christopherthielen
Copy link
Contributor

Allow $state.is, .get, and .includes to work on relative stateOrName
with a passed-in context for relative lookups.

Allow $state.is, .get, and .includes to work on relative stateOrName
with a passed-in context for relative lookups.
@christopherthielen
Copy link
Contributor Author

I cleaned up pr #636 and added some docs. I switched the extra param in .get() from options to context with nate's advice to avoid BC.

@nateabele @timkindberg Take one more look before I merge this in and finalize the API change. Note that .get() uses contextwhile .is and .includes use options.relative.

@nateabele
Copy link
Contributor

👍

christopherthielen added a commit that referenced this pull request Sep 15, 2014
feat($state): is/includes/get work on relative stateOrName
@christopherthielen christopherthielen merged commit 355d5a1 into angular-ui:master Sep 15, 2014
@christopherthielen christopherthielen added this to the 0.2.12 milestone Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants