Skip to content

fix(uiView): allow interpolated ui-view names #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2014
Merged

fix(uiView): allow interpolated ui-view names #1368

merged 1 commit into from
Sep 15, 2014

Conversation

christopherthielen
Copy link
Contributor

Made internal function getUiViewName allow interpolated values.
Added test for issue #1324

Closes #1324

Made internal function getUiViewName allow interpolated values.
Added test for issue #1324

Closes #1324
@christopherthielen
Copy link
Contributor Author

@nateabele @timkindberg do we support interpolated name, i.e., <ui-view="fo{{var}}"/>? I've always been unsure on that point. See:

https://github.com/christopherthielen/ui-router/compare/issue-1324?expand=1#diff-98cb61fc2fd982fbc899b65f857abbbbR426

@nateabele
Copy link
Contributor

@christopherthielen I don't see a compelling reason not to support it. Having said that, I don't think <ui-view="foo{{var}}"/> is valid syntax. It'd either have to be <div ui-view="foo{{var}}"/> or <ui-view name="foo{{var}}"/>.

Patch looks good, btw.

@christopherthielen
Copy link
Contributor Author

yeah, oops on the invalid example. I was basing my question about interpolated ui-view name on the comments in #395. With that cleared up, I'll merge this in.

edit: I just realized 395 is for ui-sref, not ui-view.

christopherthielen added a commit that referenced this pull request Sep 15, 2014
fix(uiView): allow inteprolated ui-view names
@christopherthielen christopherthielen merged commit 2e71853 into angular-ui:master Sep 15, 2014
@christopherthielen christopherthielen changed the title fix(uiView): allow inteprolated ui-view names fix(uiView): allow interpolated ui-view names Sep 15, 2014
@christopherthielen christopherthielen deleted the issue-1324 branch September 15, 2014 01:51
@christopherthielen christopherthielen added this to the 0.2.12 milestone Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic view names broken 0.2.11
2 participants