Adding 'reloadOnPath' and 'reloadOnQuery' configuration to the state. #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter is 'path' or 'query'
…rations to permit url changes without controller and/or view reloads. Useful when you want reflect changes in the $stateParams and url without having to recreate/reload controllers and views.
…ery' state configurations
|
Thanks for the PR, but this functionality is already in progress under a different approach. |
|
Thanks @nateabele. This is good news, I'll be looking forward to the patch. Is there a link where I can track the release of this feature so I can incorporate it when it's completed and released? |
nateabele
added a commit
to nateabele/ui-router
that referenced
this pull request
Aug 22, 2014
`$stateParams` is now a service with an `$observe()` method to watch parameters on dynamic state parameters. Dynamic state parameters can be declared like so: `params: { foo: { dynamic: true } }`.
Closes angular-ui#1037, angular-ui#1038, angular-ui#64
nateabele
added a commit
to nateabele/ui-router
that referenced
this pull request
Sep 9, 2014
`$stateParams` is now a service with an `$observe()` method to watch parameters on dynamic state parameters. Dynamic state parameters can be declared like so: `params: { foo: { dynamic: true } }`.
Closes angular-ui#1037, angular-ui#1038, angular-ui#64
|
@nateabele I'm very keen to use the functionality you added in the |
gGonz
pushed a commit
to gGonz/ui-router
that referenced
this pull request
Mar 13, 2015
`$stateParams` is now a service with an `$observe()` method to watch parameters on dynamic state parameters. Dynamic state parameters can be declared like so: `params: { foo: { dynamic: true } }`.
Closes angular-ui#1037, angular-ui#1038, angular-ui#64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reloading and recreation of the controllers and views when modifying search parameters prohibits any smooth UI as the DOM as well as scopes are discarded. The current 'reloadOnSearch' stops the transition, however it fails to update the $location.search(), more importantly, it fails to reflect the changes to the $stateParams which applications rely on for reactive code ($watch).
The configuration of 'reloadOnPath' and/or 'reloadOnQuery' being set to 'false' will update the url, update the $stateParams and suppress the reloading of the controllers and views. One can specify the same configurations when using $state.transitionTo() as well as other wrappers around it ($state.go()).