Global variable issue

[sandyplace]

Several variables are defined at the top of angular-ui-states.js. These variables are essentially global as the file is not wrapped in a closure.

var isDefined = angular.isDefined,
    isFunction = angular.isFunction,
    isString = angular.isString,
    isObject = angular.isObject,
    isArray = angular.isArray,
    forEach = angular.forEach,
    extend = angular.extend,
    copy = angular.copy;

I am using another package called showdown.js which also has var forEach.. defined. It is overwriting the one declared in the angular-ui-states.js library which is throwing an exception. I fixed this by enclosing the entire angular-ui-states.js library in a closure:

(function(){
    'use strict';

var isDefined = angular.isDefined,
    isFunction = angular.isFunction,
    isString = angular.isString,
    isObject = angular.isObject,
    isArray = angular.isArray,
    forEach = angular.forEach,
    extend = angular.extend,
    copy = angular.copy;
...
)();

[ksperling]

Hm, the anonymous function used to be there... looks like with the change to grunt 0.4 those snippets from the grunt file aren't being included anymore...

[jeme]

I can add that back in the same way i do in my own solution, by adding pre- and suf-fix files or will you look at it @ksperling ?

[ksperling]

just committing it