Skip to content

ui-sref-active not working for state based (url-less) navigation #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samccone opened this issue Jan 6, 2014 · 0 comments · Fixed by #740
Closed

ui-sref-active not working for state based (url-less) navigation #738

samccone opened this issue Jan 6, 2014 · 0 comments · Fixed by #740

Comments

@samccone
Copy link
Contributor

samccone commented Jan 6, 2014

So, some apps do not use urls and instead use state changes.

Thus this line is evaluating to false,

https://github.com/angular-ui/ui-router/blame/86eacac09ca5e9000bd3b9c7ba6e2cc95d883a3a/src/stateDirectives.js#L68

because of this
https://github.com/angular-ui/ui-router/blame/86eacac09ca5e9000bd3b9c7ba6e2cc95d883a3a/src/stateDirectives.js#L66

Essentially checking the states href to determine if state has changed is incorrect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix uiSrefActive state for urlless navigation samccone/ui-router
1 participant
@samccone