V1.1.0 - TypeError: Cannot read properties of undefined (reading 'inherit')

[p3pp8]

After updating to version 1.1.0 i'm not able to run my app anymore. I use AngularJS 1.8.3.

TypeError: Cannot read properties of undefined (reading 'inherit')
    at StateParams.$inherit (factory.js:63:9)
    at StateService.href (factory.js:63:9)
    at BaseUrlRule.handler (factory.js:63:9)
    at UrlService.sync (factory.js:63:9)
    at factory.js:63:9
    at factory.js:63:9
    at Array.forEach (<anonymous>)
    at factory.js:63:9
    at Scope.$broadcast (factory.js:63:9)
    at afterLocationChange (factory.js:63:9)
    at factory.js:63:9
    at Scope.$digest (factory.js:63:9)
    at Scope.$apply (factory.js:63:9)
    at bootstrapApply (factory.js:63:9)
    at Object.invoke (factory.js:63:9)
    at doBootstrap (factory.js:63:9)
(

I did not find any changelog and/or migration instructions. Any help is really appreciated.

[wawyed]

Make sure that you manually specify @uirouter/core in your package.json

[p3pp8]

Hello, thanx for the answer. I did it, i added "@uirouter/core": "^6.1.0" dep into package.json but still have the same error. Do i need to inject it into the angularjs scope?

[wawyed]

Are you using any other packages from uirouter?

[p3pp8]

Ah sorry, didn't catch! No, no other package, only angularjs and core.

[wawyed]

Which version did you update from?

[p3pp8]

1.0.30 and it works perfectly!

[wawyed]

I can't see anything that'd make it break. Can you try uirouter/core 6.0.8?

[p3pp8]

Just tested using core 6.0.8 and that fixed the problem, works like a charm!

[p3pp8]

6.0.9 breaks as for 6.1.0

[wawyed]

I think I found out what the problem is. Do you have params declarations as strings instead of objects?

[p3pp8]

Uhmmm, params in state are always declared as objects like this:

$stateProvider
        .state('myStateName', {
            url: '/myPage',
            params: {
                a: null,
                b: null
            }
        });

I've looked into all the project and unfortunately i didn't find any param defined as string, only objects.

[wawyed]

You just showed me the issue :D. The value of the param is null which is not an object :D

[p3pp8]

Ok, i'm going to cleanup my code! Thank you!!!!

[wawyed]

Well, I think your case is still supported so I'll add a fix for your case!

[wawyed]

@p3pp8 I'm having some issues reproducing the issue in the unit tests. Would you be able to send me a basic state declaration structure that makes this fail? So that I can test my fix.