Skip to content

cfg.getTemplate is undefined when using angular global #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
milo- opened this issue Jan 17, 2017 · 6 comments
Closed

cfg.getTemplate is undefined when using angular global #3275

milo- opened this issue Jan 17, 2017 · 6 comments

Comments

@milo-
Copy link

milo- commented Jan 17, 2017

Looks like the angular global isn't being used on this line https://github.com/angular-ui/angular-ui-router-bower/blob/1.0.0-rc.1/release/angular-ui-router.js#L8742

This results in cfg.getTemplate being undefined when using the angular (bower installed) global.

The break was introduced in: af95206#diff-a9f6de4806aaa114899aac7111e5235fR360

This is related to 2982613

@christopherthielen
Copy link
Contributor

Thanks for the report

@hoeni
Copy link

hoeni commented May 26, 2017

https://github.com/angular-ui/ui-router/pull/3410/files fixes the error in my case.

@noway
Copy link

noway commented Jul 13, 2017

This is pretty annoying as because it renders angular-ui-extras impossible to use with the latest (1.0) ui-router.

And angular-ui-extras provides pretty essential features like future states...

Would be nice to get that fixed. angular-ui-extras+1.0 ui-router will be a very powerful combination (having components routing and dynamic module loading is huge).

david-dlc-cerezo added a commit to david-dlc-cerezo/media-app-vod that referenced this issue Aug 22, 2017
@senthanal
Copy link

👍
I do get the same annoying error. I can't proceed to deploy my application. Am waiting for this fix. Is there a plan to merge this pull request anytime soon? Pls. Thanks :)

@noway
Copy link

noway commented Nov 11, 2017

Because of this, it is impossible to route dynamically loaded components with AngularJS. IMHO this is pretty high priority.

@christopherthielen
Copy link
Contributor

christopherthielen commented Nov 11, 2017

I'd like to fix this. The linked PR is a band aid and doesn't address the root issue (with angular global). Can anyone post a link to a reproduction of this error?

edit: nevermind, this repo reproduces the error: https://github.com/christopherthielen/ui-router-webpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants