Skip to content

ng2.UISrefActive: Doesn't work when the UISref is on a different element #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christopherthielen opened this issue Aug 28, 2016 · 0 comments
Closed

ng2.UISrefActive: Doesn't work when the UISref is on a different element #2950

christopherthielen opened this issue Aug 28, 2016 · 0 comments
Labels
1.0 bug
Milestone
1.0.0-beta.2

Comments

@christopherthielen
Copy link
Contributor

See ui-router/quickstart-ng2#10

The bug is from how we access the UISref in the UISrefStatus: by injecting it into the constructor here: https://github.com/angular-ui/ui-router/blob/master/src/ng2/directives/uiSrefStatus.ts#L58

We should probably be using the ContentChild feature to find the child UISref(s): https://angular.io/docs/ts/latest/api/core/index/ContentChild-var.html
@christopherthielen christopherthielen added this to the 1.0.0-beta.2 milestone Aug 28, 2016
christopherthielen added a commit that referenced this issue Aug 31, 2016
@christopherthielen
fix(ng2.uiSrefActive): Allow uiSrefActive on ancestor element.
874fc07 
feat(ng2.uiSrefActive): Refactor using observables
Closes #2950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 bug
Projects
None yet
Milestone
1.0.0-beta.2
Development

No branches or pull requests
1 participant
@christopherthielen