-
Notifications
You must be signed in to change notification settings - Fork 3k
Why ui-view doesn't work into components template? #2574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@tamtakoe missing |
@kukac7 I have updated my plnkr (added otherwise and templateUrl). It works good but only in plnkr. On local server it doesn't work. This is problem in templateUrl |
@tamtakoe there's nothing wrong with it, works well. |
If it doesn't work locally but does work elsewhere then I would examine your local setup to see whats different. Closing as this doesn't seem like a ui-router issue. |
@eddiemonge, @kukac7 This problem occurs because of $location service. See example: If you remove problem service, app will works good |
That looks like a core angular problem |
It doesn't matter what you put into the run argument list, even nothing in there breaks it. |
I created an issue in angular repository angular/angular.js#14201 Investigate this problem, please. In what place and what time it appear. I or Angular team can not do it effectively, because we are not ui-router specialists. |
This might be a problem similar to angular/angular.js#1213 (A fix for this was merged, but it's not in a release yet). But the exact problem is different. With uiRoute, injecting location breaks the state update. I would say that this is a uiRouter bug. |
It works if you add $state near $location dependency http://plnkr.co/edit/GlZgwMSJjuSt0AVjT2zc?p=preview |
This was indeed an issue very similar to the one pointed out by @Narretz. |
This is the original commit that fixed this if anyone is curious: 46cf53d |
👍 |
Thanks all. For others, the @tamtakoe workaround is simple: |
Fixed in de3a04a |
I am working on a legacy project with Angular 1.5 and ui-router 0.2. I am trying to upgrade it progressively to newer versions. Upgrading to ui-router 0.3 or 0.4 breaks the history.back() behaviour (if I go from state1 to state2 to state3 then back, it goes back to state1 instead of state2). I figured out that replacing Any idea? Many thanks |
@mickaeltr Not sure. I don't think the constant |
@christopherthielen More precisely, my problem actually comes from |
As for the back button, I'd try the latest version 1.0.10 |
I'd like that but upgrading ui-router from 0.x to 1.x requires quite some work. So for now we'll have to stick to 0.2.18. Thanks @christopherthielen |
http://plnkr.co/edit/SKYVVGWw2GqABPoQHg8E?p=preview
The text was updated successfully, but these errors were encountered: