Skip to content

1.0.0-alpha0 parent/child query parameters not format()ted correctly #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christopherthielen opened this issue Jan 31, 2016 · 4 comments
Closed

1.0.0-alpha0 parent/child query parameters not format()ted correctly #2504

christopherthielen opened this issue Jan 31, 2016 · 4 comments
Assignees
@christopherthielen
Labels
1.0 bug
Milestone
1.0.0-alpha.1

Comments

@christopherthielen
Copy link
Contributor

https://plnkr.co/edit/eP09lKTynJjblgTyprvZ?p=preview

Failing unit test:

 it("should handle additional query parameters from concated matchers", function() {
      var m = new UrlMatcher('/parent?qParent');
      var m2 = m.append(new UrlMatcher('/child?qChild'));
      var formatted = m2.format({ qParent: 'parent', qChild: 'child' });

      expect (formatted).toBe('/parent/child?qParent=parent&qChild=child');
    })```
@christopherthielen christopherthielen added this to the 1.0.0-alpha.1 milestone Jan 31, 2016
@christopherthielen christopherthielen self-assigned this Jan 31, 2016
@pavel-blagodov
Copy link

Could you tell me the approximate date of 1.0.0-alpha.1release?

christopherthielen added a commit that referenced this issue Jan 31, 2016
@christopherthielen
test(urlMatcher): Add failing test for #2504 improper parent/child qu…
7792134 
…ery params formatting
@christopherthielen
Copy link
Contributor Author

Could be as soon as next week. Are you looking for any fix to alpha0 in particular?

@pavel-blagodov
Copy link

Yes, I'm. It would be great if this issue could be fixed asap.

@zivc zivc mentioned this issue Feb 3, 2016
Closed
christopherthielen added a commit that referenced this issue Feb 14, 2016
@christopherthielen
fix(UrlMatcher): Format parent/child UrlMatchers properly
86e07ef 
Build arrays of path parameters and query parameters for the entire path of UrlMatchers.  Map/reduce them, then concatenate at the end.
closes ##2504
@christopherthielen
Copy link
Contributor Author

Fixed in 86e07ef

ns-codereview pushed a commit to couchbase/ns_server that referenced this issue Feb 17, 2016
@pavel-blagodov @dave-finlay
MB-12222: update ui-router to version 1.0.0 alpha0
cc7ef04 
We have to use latest ui router because it has transitionsProvider,
we need transitionsProvider in order to properly handle transition
to the state with rbac permissions
https://github.com/angular-ui/ui-router/releases/tag/1.0.0alpha0

Old ui-router is deprecated
https://github.com/angular-ui/ui-router/releases/tag/0.2.17

Process of migrating is pretty smooth, although there are couple bugs
angular-ui/ui-router#2504
angular-ui/ui-router#2503

Change-Id: I67fc81adecf5ebf9cf294171d5583f8555696cee
Reviewed-on: http://review.couchbase.org/59318
Reviewed-by: Dave Finlay <[email protected]>
Tested-by: Dave Finlay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christopherthielen christopherthielen

Labels
1.0 bug
Projects
None yet
Milestone
1.0.0-alpha.1
Development

No branches or pull requests
2 participants
@pavel-blagodov @christopherthielen