Update of child scopes broken

[m7r]

To reproduce run the example at current head and try to switch between alice and bob.
Nothing happens. Switching between contact.list and contact.detail works as aspected.

If you change the url manually there is the same problem. Only in html5 mode it works, as the browser reloads the hole page.

It looks like the problem was introduced with 2874694

[ksperling]

hmmm... I guess the problem is that we're not comparing parameters in that code, but that would get pretty complicated.

Maybe another option for avoiding the $location problem with non-navigable states would be for $state to remember the last URL that it thinks $location should have, and only do a transition if they differ. I.e. we'd update that location

• after we've processed a $location / $urlMatcher handler
• after we've updated $location in transitionTo()

@nateabele thoughts?

[nateabele]

@ksperling You don't think it would work to compare $match to $stateParams? (I guess once your parameter work is complete, we would have to compare the encoded version of each param...)

Or, could we just generate a URL for the other state and compare them directly?

[ksperling]

The problem with generating a URL in the route handler and comparing to the current state is that there can be multiple representations of the same URL (e.g. query parameter order can differ, but there may be other ways).

The problem we were trying to fix in the original change was that an update to $location we initiate ourselves causes an instant transition; so the simplest fix would seem to be to remember that we've set the url to X, so if we get a callback that the url is now X on the next digest cycle, we know we can just ignore it.

[nateabele]

Yeah okay, that makes more sense now. Sounds good to me.

[nateabele]

Fixed in fdc1156 (see #289).