Skip to content

Commit 500ecda

Browse files
cherry-pick 41acad8 from 0.2.17
1 parent 91c1ff1 commit 500ecda

File tree

4 files changed

+20
-9
lines changed

4 files changed

+20
-9
lines changed

test/testUtils.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,13 @@
22
/// <reference path='../typings/jasmine/jasmine.d.ts' />
33

44
// Promise testing support
5-
angular.module('ngMock').config(function ($provide) {
5+
angular.module('ngMock').config(function ($provide, $locationProvider) {
6+
var oldFn = $locationProvider.html5Mode;
7+
$locationProvider.html5Mode = function() {
8+
var retval = oldFn.apply($locationProvider, arguments);
9+
return (angular.isDefined(retval) && angular.isDefined(retval.enabled)) ? retval.enabled : retval;
10+
};
11+
612
$provide.decorator('$q', function ($delegate, $rootScope) {
713
$delegate.flush = function() {
814
$rootScope.$digest();

test/urlMatcherFactorySpec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ var common = uiRouter.common;
66
var prop = common.prop;
77

88
beforeEach(function() {
9-
var app = angular.module('ui.router.router.test', function () { });
9+
var app = angular.module('ui.router.router.test', []);
1010
app.config(function ($urlMatcherFactoryProvider) {
1111
provider = $urlMatcherFactoryProvider;
1212
UrlMatcher = provider.UrlMatcher;

test/urlRouterSpec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe("UrlRouter", function () {
1010
describe("provider", function () {
1111

1212
beforeEach(function() {
13-
angular.module('ui.router.router.test', function() {}).config(function ($urlRouterProvider) {
13+
angular.module('ui.router.router.test', []).config(function ($urlRouterProvider) {
1414
$urlRouterProvider.deferIntercept();
1515
$urp = $urlRouterProvider;
1616
});
@@ -51,7 +51,7 @@ describe("UrlRouter", function () {
5151
describe("service", function() {
5252

5353
beforeEach(function() {
54-
angular.module('ui.router.router.test', function() {}).config(function ($urlRouterProvider, $locationProvider) {
54+
angular.module('ui.router.router.test', []).config(function ($urlRouterProvider, $locationProvider) {
5555
$urp = $urlRouterProvider;
5656
$lp = $locationProvider;
5757

test/viewDirectiveSpec.js

+10-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
var module = angular.mock.module;
22
var uiRouter = require("angular-ui-router");
33

4+
function animateFlush($animate) {
5+
$animate && $animate.triggerCallbacks && $animate.triggerCallbacks(); // 1.2-1.3
6+
$animate && $animate.flush && $animate.flush(); // 1.4
7+
}
8+
49
describe('uiView', function () {
510
'use strict';
611

@@ -160,7 +165,7 @@ describe('uiView', function () {
160165
$q.flush();
161166
if ($animate) {
162167
expect(log).toBe('m;n;');
163-
$animate.triggerCallbacks();
168+
animateFlush($animate);
164169
expect(log).toBe('m;n;$destroy(m);');
165170
} else {
166171
expect(log).toBe('m;$destroy(m);n;');
@@ -297,7 +302,7 @@ describe('uiView', function () {
297302
$state.transitionTo(aState);
298303
$q.flush();
299304

300-
if ($animate) $animate.triggerCallbacks();
305+
animateFlush($animate);
301306

302307
expect($uiViewScroll).not.toHaveBeenCalled();
303308
}));
@@ -307,7 +312,7 @@ describe('uiView', function () {
307312
$state.transitionTo(aState);
308313
$q.flush();
309314

310-
if ($animate) $animate.triggerCallbacks();
315+
animateFlush($animate);
311316

312317
expect($uiViewScroll).toHaveBeenCalledWith(elem.find('span').parent());
313318
}));
@@ -320,15 +325,15 @@ describe('uiView', function () {
320325
$state.transitionTo(aState);
321326
$q.flush();
322327

323-
if ($animate) $animate.triggerCallbacks();
328+
animateFlush($animate);
324329

325330
expect($uiViewScroll).not.toHaveBeenCalled();
326331

327332
scope.doScroll = true;
328333
$state.transitionTo(bState);
329334
$q.flush();
330335

331-
if ($animate) $animate.triggerCallbacks();
336+
animateFlush($animate);
332337

333338
var target,
334339
index = -1,

0 commit comments

Comments
 (0)