cherry-pick e00aa69 from 0.2.17; also re-implement global variable $state.transition for backwards compat.

Author: christopherthielen

src/ng1/stateEvents.ts

@@ -28,8 +28,8 @@ import {Transition} from "../transition/transition";
     return memo;
   }
 
-  stateChangeStartHandler.$inject = ['$transition$', '$stateEvents', '$rootScope', '$urlRouter'];
-  function stateChangeStartHandler($transition$: Transition, $stateEvents, $rootScope, $urlRouter) {
+  stateChangeStartHandler.$inject = ['$transition$', '$stateEvents', '$rootScope', '$state', '$urlRouter'];
+  function stateChangeStartHandler($transition$: Transition, $stateEvents, $rootScope, $state, $urlRouter) {
     if (!$transition$.options().notify || !$transition$.valid() || $transition$.ignored())
       return;
 
@@ -70,7 +70,8 @@ import {Transition} from "../transition/transition";
         if (enabledEvents.$stateChangeCancel) {
           $rootScope.$broadcast('$stateChangeCancel', $transition$.to(), toParams, $transition$.from(), fromParams, $transition$);
         }
-        $urlRouter.update();
+        //Don't update and resync url if there's been a new transition started. see issue #2238, #600
+        if ($state.transition == null) $urlRouter.update();
         return false;
       }
 

src/state/hooks/transitionManager.ts

@@ -64,11 +64,16 @@ export class TransitionManager {
   runTransition(): IPromise<any> {
     this.activeTransQ.clear();  // TODO: nuke this
     this.activeTransQ.enqueue(this.transition);
+    this.$state.transition = this.transition;
     let promise = this.transition.run()
         .then((trans: Transition) => trans.to()) // resolve to the final state (TODO: good? bad?)
         .catch(error => this.transRejected(error)); // if rejected, handle dynamic and redirect
 
-    let always = () => this.activeTransQ.remove(this.transition);
+    let always = () => {
+      this.activeTransQ.remove(this.transition);
+      if (this.$state.transition === this.transition) this.transition = null;
+    };
+
     promise.then(always, always);
 
     return promise;

test/stateSpec.js

@@ -1994,3 +1994,35 @@ describe('$stateParams', function () {
     expect($stateParams.foo).toBeUndefined();
   }));
 });
+
+// Test for #600, #2238, #2229
+describe('otherwise and state redirects', function() {
+  beforeEach(module('ui.router.state.events', function($stateEventsProvider) {
+    $stateEventsProvider.enable();
+  }));
+
+  beforeEach(module(function ($stateProvider, $urlRouterProvider) {
+    $urlRouterProvider.otherwise('/home');
+    $stateProvider
+        .state('home', { url: '/home', template: 'home' })
+        .state('loginPage', { url: '/login', templateUrl: 'login.html' });
+  }));
+
+  beforeEach(inject(function ($rootScope, $state) {
+    $rootScope.$on('$stateChangeStart', function (event, toState) {
+      if (toState.name !== "loginPage") {
+        event.preventDefault();
+        $state.go('loginPage', { redirectUrl: toState.name });
+      }
+    });
+  }));
+
+  it("should not go into an infinite loop", inject(function($location, $rootScope, $state, $urlRouter, $httpBackend) {
+    $httpBackend.expectGET("login.html").respond("login page");
+    $location.url("notmatched");
+    $urlRouter.update(true);
+    expect(function() { $rootScope.$digest(); }).not.toThrow();
+    expect(function() { $httpBackend.flush(); }).not.toThrow();
+    expect($state.current.name).toBe("loginPage")
+  }));
+});