Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Fix tooltip in angular 1.2.0. #975

Closed
wants to merge 2 commits into from

Conversation

jimrollenhagen
Copy link
Contributor

Use bind-html-unsafe instead of ng-bind-html-unsafe, as per #813.

@pkozlowski-opensource
Copy link
Member

@jimrollenhagen thnx for your PR but this was already addressed in 7589339. Arguably it is not the best approach but what you are proposing would force people to include the ngSanitize module and as such it should be documented, demo site updated etc.

Based on the above reasons I'm going to close this PR but I'm happy to discuss this in more details.

@jimrollenhagen
Copy link
Contributor Author

@pkozlowski-opensource I think you may have read my PR wrong?

In 7589339 you added the ui.bootstrap.bindHtml dependency to the tooltip module, but never used it. The typeahead template was changed to bind-html-unsafe but the tooltip was not updated.

My commit simply addresses this issue.

@pkozlowski-opensource
Copy link
Member

@jimrollenhagen I must have been half-asleep, thnx for waking me up! Landed as 08d8b21, thank you!

@jimrollenhagen
Copy link
Contributor Author

No problem, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants