Angular 1.3.0 rc0 causes datepicker to display initial date as unformatted string

[byudaniel]

The behavior of $viewValue has changed in this commit. Angular 1.3 rc0 sets $viewValue for dates as a string, so date formatting fails.

[davisford]

Yea, I'm seeing this as well. Last release I had before upgrading to 1.3 rc0 that I knew worked was angular#1.3.0-build.3102+sha.a9371a1. I tried a few pre-1.3 rc0, but they also weren't working, so I rolled back to that version.

Notably, this also seems to have broken Angular-UI Bootstrap typeahead, with a similar issue $viewValue is broken there (see this issue). In the angular expression thing as thing.name for thing in things, it ends up displaying as [Object object] instead of displaying thing.name.

[bcronje]

I have the same problem. Any idea how to fix this?

[bcronje]

Here's a fix:

After line https://github.com/angular-ui/bootstrap/blob/master/src/datepicker/datepicker.js#L525 add the following formatter:

ngModel.$formatters.push(function (value) {
  return ngModel.$isEmpty(value) ? value : dateFilter(value, dateFormat);
});

@pkozlowski-opensource Do you have any objections for this? Essentially as @byudaniel indicated, this commit. in AngularJS 1.3 rc0 sets $viewValue for dates as a string. Adding the above $formatter ensures the date is formatted using dateFilter before the default string formatter.

[mgibas]

Same issue here - @bcronje fix helps

[DaveWM]

Thanks @bcronje, I've submitted a pull request with your fix. I also had to update the $render function, otherwise any changes to the date format are ignored.

[M0nter0]

Thanks @bcronje, It's working but then I found another issue. When the format changes but not the value, if datefilter() receives an String not matching R_ISO8601_STR it doesn't change the format.

attrs.$observe('datepickerPopup', function(value) {
      dateFormat = value || datepickerPopupConfig.datepickerPopup;
      ngModel.$render();
  });

// Outter change
  ngModel.$render = function() {
    var date = ngModel.$viewValue ? dateFilter(ngModel.$viewValue, dateFormat) : '';
    element.val(date);
    scope.date = parseDate( ngModel.$modelValue );
  };

I've fix it modifying line 549 to pass the object as Date instead of String https://github.com/angular-ui/bootstrap/blob/master/src/datepicker/datepicker.js#L549 from

var date = ngModel.$viewValue ? dateFilter(ngModel.$viewValue, dateFormat) : '';

to

var date = ngModel.$viewValue ? dateFilter(ngModel.$modelValue, dateFormat) : '';

I don't know if this modification could provoke side errors.