Collapse doesn't work with BS3

[pkozlowski-opensource]

We've got a number of PRs that need to be reviewed / merged.

[RobJacobs]

@pkozlowski-opensource I've been testing this commit, found a small issue. In the function collapse() - if (initialAnimSkip) I believe you should be setting initialAnimSkip = false like you do in the expand function.

Also would be nice to have the isOpen attribute in the Accordion named the same as the Collapse directive - collapse attribute.

[RavBiarri]

I also encountered this issue. This ended up being a collapse error in bootstrap.css. To solve, I just commented out the following code in bootstrap.css:

.collapse {
display: none;
}

.collapse.in {
display: block;
}

[chrisirhc]

@pkozlowski-opensource I'm hoping when you do release 0.8 for Bootstrap 3.0, there'll be a maintenance branch for Bootstrap 2 (0.7.x perhaps) as I'm quite sure that there'll be many users (I'm one of them) who won't be switching to Bootstrap 3.0 that soon.

Meanwhile, I'm reviewing this commit and have found some issues. Will send you a pull request in a short while.

[pkozlowski-opensource]

@chrisirhc yup, I'm going to create a maintenance branch of 0.7.0 (that was just released this weekend) for BS2.3 / AngularJS1.0. I will try to cherry-pick fixes to this branch and do regular releases for some time. But inevitably inevitably we are going to drop support for BS2.3 before 1.0 release (I can't really say when it is going to happen).

In short: yes, we are going to have a BS2 maintenance branch for some time but one needs to expect that support for it is going to be dropped in the future.

[chrisirhc]

@pkozlowski-opensource sounds great. If someone really needs support for BS2.3, they can maintain a fork, anyway. 👍

[vkelman]

@pkozlowski-opensource - you had a plunk provided an example of Collapse working with Bootstrap 3, which included your updated versions of collapse.js and transition.js. Now this plunk seems to be disappeared, while UI Bootstrap still doesn't work with Bootstrap 3.
Could you please re-post that plunk? (I think there was a failure with Plunker, my own plunk disappeared as well.)

Thank you

[pkozlowski-opensource]

It is fixed in the Bootstrap3 branch now. Thnx for the awesome help @chrisirhc !